ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941) by dezren39 · Pull Request #2721 · developing-today/code

dezren39 · 2026-10-30T11:54:41Z

Closes the implementation for #1941 (Approach C), now that its gate has landed: PR #2629 merged .#mcpx-docs to main (#1939).

What

One new file, .github/workflows/mcpx-docs.yml:

PRs touching pkgs/mcpx/**, flake.nix, flake.lock, or the workflow itself: build .#mcpx-docs (Determinate nix installer + magic-nix-cache with FlakeHub off, matching mcpx-nixbuild.yml) and upload the rendered site as the mcpx-docs-site artifact. No deploy, no PR previews.
Pushes to main / workflow_dispatch: a separate deploy job (needs build, main-ref only) rebuilds the same output and deploys via actions/configure-pages + actions/upload-pages-artifact + actions/deploy-pages in the github-pages environment.
Permissions: top-level contents: read; only the deploy job adds pages: write and id-token: write. mcpx.yml is untouched.
Serialised deploys: deploy job concurrency group pages, cancel-in-progress: false.

Pages enablement (done as part of this change)

GitHub Pages has been enabled on this repository with the Actions source:

gh api -X POST repos/developing-today/code/pages -f build_type=workflow
→ build_type: workflow, html_url: https://developing-today.github.io/code/, https_enforced: true

Base URL

The .#mcpx-docs output does not accept a base-URL/site-url argument, so — per the packet's fallback — local and CI builds are identical rather than differing only in that value. The plumbing sketch is filed back as a note on #1939. mdBook's relative links work under the /code/ project path without it.

Verification

CI on this PR is the verification: the new workflow's build job must build .#mcpx-docs and upload the artifact. Post-merge, a workflow_dispatch run deploys and the Pages URL serves the book index (tracked on #1941).

Queue task 3242 · issue #1941

^{Need help on this PR? Tag @codesmith-bot with what you need.}

coderabbitai · 2026-10-30T11:54:50Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 3e3e0aab-e2a5-47e5-b6d2-789e16cd0c9d

Commits

Reviewing files that changed from the base of the PR and between a062548 and a45cc7c.

Files selected for processing: 2

.github/workflows/mcpx-docs.yml
pkgs/mcpx/docs.nix

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-10-30T11:54:53Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-30T19:57:39.633122Z	`a45cc7c`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

dezren39 · 2026-10-30T11:59:08Z

🤖 Agent note · parked (CI pending)

Agent: repo-worker-code, Lane A shift
Session / ID: queue task 3242
Found via: queue claim (gate cleared this shift — PR docs(mcpx): stand up the mdBook book and .#mcpx-docs flake output (#1939) #2629 merged, .#mcpx-docs on main)
Task: Implemented: PR ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941) #2721 adds .github/workflows/mcpx-docs.yml (PR build + artifact; main/dispatch deploy via Pages Actions, pages concurrency group, deploy-only pages: write + id-token: write); GitHub Pages enabled with Actions source (build_type=workflow, https://developing-today.github.io/code/). Base-URL plumbing note filed back on mcpx docs: choose the site generator (mdBook, MkDocs Material, Docusaurus, Starlight, Hugo) #1939 (comment 6522045273).
Expectation: parked 20 min on CI — the new workflow's build: nix build .#mcpx-docs job (run 41051467951) was still pending at the 5-minute mark. Resume: check that job + Codex findings on PR ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941) #2721 (none posted yet); if green and findings dispositioned, merge, then run a workflow_dispatch deploy and verify the Pages URL serves the book index before closing this issue.
Links: PR ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941) #2721 · branch queue/3242-1941-mcpx-docs-pages · laptop worktree ~/git/fleet/3242

dezren39 · 2026-10-30T11:59:36Z

Correction to the park note above: the Codex review for this PR has completed at head c8bf85d with no findings (codex-review-state: has_any_findings=false, has_unresolved_findings=false). The only remaining resume step is the pending build: nix build .#mcpx-docs job (run 41051467951); if it goes green, the PR is merge-ready under the standing criteria, followed by a workflow_dispatch deploy + Pages URL check on #1941.

…#1941)

dezren39 · 2026-10-30T19:49:06Z

Resumed by queue worker lane E (task 3242). The workflow as opened satisfied the triggers/permissions/deploy spec and its build was green with a clean Codex round, but the packet for #1941 also requires the base URL to be baked in as a build/derivation argument — the first pass explicitly punted that to a note on closed #1939. Added in 1adeeba: pkgs/mcpx/docs.nix now takes a siteUrl argument (default "/", the Pages Actions deploy root), exported as mdBook's MDBOOK_OUTPUT__HTML__SITE_URL, so local/CI/custom-domain builds differ only in that value; the workflow header comment is updated to match. This PR's own build job exercises the changed derivation.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1adeebaa36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…h (404 page assets, #1941)

ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941)

c8bf85d

dezren39 requested a review from a team as a code owner October 30, 2026 11:54

dezren39 mentioned this pull request Oct 30, 2026

mcpx docs: build the site in CI and deploy to GitHub Pages #1941

Closed

github-actions Bot assigned dezren39 Oct 30, 2026

ci(mcpx): bake base URL as the mcpx-docs derivation argument (siteUrl, …

1adeeba

…#1941)

chatgpt-codex-connector Bot reviewed Oct 30, 2026

View reviewed changes

Comment thread .github/workflows/mcpx-docs.yml Resolved

ci(mcpx): deploy the book with siteUrl /code/ — the project Pages pat…

a45cc7c

…h (404 page assets, #1941)

dezren39 merged commit 1a7a1b3 into main Oct 30, 2026
7 checks passed

dezren39 deleted the queue/3242-1941-mcpx-docs-pages branch October 30, 2026 19:58

dezren39 restored the queue/3242-1941-mcpx-docs-pages branch November 1, 2026 09:05

dezren39 deleted the queue/3242-1941-mcpx-docs-pages branch November 1, 2026 16:45

This was referenced Nov 3, 2026

Preserved branch: queue/3242-1941-mcpx-docs-pages — decision needed (merge / cherry-pick / drop) #3657

Closed

mcpx docs: a custom subdomain for the site (DNS, CNAME, HTTPS) #1943

Open

Navigation Menu

Repository navigation

ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941) - #2721

ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941)#2721
dezren39 merged 3 commits into
mainfrom
queue/3242-1941-mcpx-docs-pages

dezren39 commented Oct 30, 2026 •

edited by blacksmith-sh Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

dezren39 commented Oct 30, 2026

Uh oh!

dezren39 commented Oct 30, 2026

Uh oh!

dezren39 commented Oct 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dezren39 commented Oct 30, 2026 • edited by blacksmith-sh Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Pages enablement (done as part of this change)

Base URL

Verification

Uh oh!

coderabbitai Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

dezren39 commented Oct 30, 2026

Uh oh!

dezren39 commented Oct 30, 2026

Uh oh!

dezren39 commented Oct 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dezren39 commented Oct 30, 2026 •

edited by blacksmith-sh Bot

Loading

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 30, 2026 •

edited

Loading